Refactor configuration system and modernize preferences UI - #184
Conversation
This commit ports the entire configuration system to use the new NamedConfig system, allowing for generic programmatic access to all settings through a central registry. Key changes: - Introduced INamedConfig interface for generic access. - Ported all Configuration members to NamedConfig<T>. - Refactored update propagation to use ChangeMonitor callbacks instead of legacy signals/slots between UI and observers. - Modernized Preferences UI with a search feature that filters settings across all pages. - Exposed all changeable settings (including colors) via generic CLI 'config' commands. - Bumped C++ standard to C++20.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @nschimme, your pull request is larger than the review limit of 150000 diff characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 25.10% 0.00% -25.11%
==========================================
Files 511 138 -373
Lines 42294 8320 -33974
Branches 4573 912 -3661
==========================================
- Hits 10620 0 -10620
+ Misses 31674 8320 -23354 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e8139f3 to
c119262
Compare
ae664f2 to
bcd8fca
Compare
1 participant
Ported configuration to NamedConfig, implemented generic CLI access, added preferences search, and refactored update propagation to use ChangeMonitor.
PR created automatically by Jules for task 7095629377730642300 started by @nschimme